Skip to content

Comments

feat: add selectable status indicator to toolbar v2#848

Merged
thomaswhyyou merged 20 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-8
Feb 19, 2026
Merged

feat: add selectable status indicator to toolbar v2#848
thomaswhyyou merged 20 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-8

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026 •
edited
Loading

Description

Another follow up to #846 and #847, this PR adds a "selectable" status to guide's annotation, and surfaced in GuideRow. This should be the final status indicator, which combined with other statuses should allow the toolbar to answer the question "why am i seeing or not seeing guide X"?

The "selectable" status is a bit more involved than other statuses because:

  1. It's based on multiple factors: what components are present on the current page and calling useGuide(s), what type of select queries they are issuing, whether throttling is happening at a given point in time etc.
  2. Multiple possible state values based on those factors, as explained here.

@linear
Copy link

linear bot commented Feb 2, 2026

KNO-11142 [SDK] Guide Toolbar v2 poc

@vercel
Copy link

vercel bot commented Feb 2, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 19, 2026 9:04pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 19, 2026 9:04pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 19, 2026 9:04pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 19, 2026 9:04pm

Request Review

This was referenced Feb 2, 2026
Merged
Merged
Merged
Merged
@thomaswhyyou Graphite App
Copy link
Contributor Author

thomaswhyyou commented Feb 2, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@thomaswhyyou thomaswhyyou mentioned this pull request Feb 2, 2026
Merged
@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8ddfe2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 67f3bd1 to bedf313 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-8 branch from 6f798fa to 5885839 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from bedf313 to 07cd540 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-8 branch from 5885839 to 005eede Compare February 2, 2026 21:35
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 07cd540 to e2af205 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-8 branch from 005eede to 6875fe2 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-8 branch from 40179f0 to 6426195 Compare February 19, 2026 19:29
cursor[bot]
cursor bot reviewed Feb 19, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

packages/react/src/modules/guide/components/Toolbar/V2/useInspectGuideClientStore.ts

const byKey = <T extends { key: string }>(items: T[]) => {
return items.reduce((acc, item) => ({ ...acc, [item.key]: item }), {});
};
Copy link

@cursor cursor bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated byKey utility already exists in helpers

Low Severity

The byKey helper duplicates the identical function already exported from packages/client/src/clients/guide/helpers.ts. It isn't currently re-exported from the package index, but adding it to the index.ts exports (alongside the newly added checkStateIfThrottled) would avoid the duplication.

Fix in Cursor Fix in Web

Copy link
Contributor Author

@thomaswhyyou thomaswhyyou Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

@thomaswhyyou thomaswhyyou merged commit 681b7fa into main Feb 19, 2026
13 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-11142-sdk-guide-toolbar-v2-poc-8 branch February 19, 2026 21:19
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 89.83051% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.90%. Comparing base (04a8f16) to head (d8ddfe2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 0.00% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   67.41%   67.90%   +0.49%     
==========================================
  Files         204      204              
  Lines        8561     8767     +206     
  Branches     1118     1183      +65     
==========================================
+ Hits         5771     5953     +182     
- Misses       2766     2790      +24     
  Partials       24       24
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 89.58% <100.00%> (+0.65%) ⬆️
packages/client/src/clients/guide/helpers.ts 93.52% <ø> (-0.27%) ⬇️
packages/client/src/clients/guide/index.ts 100.00% <100.00%> (ø)
packages/client/src/clients/guide/types.ts 100.00% <100.00%> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 100.00% <100.00%> (ø)
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 8.59% <0.00%> (-1.99%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@connorlindsey connorlindsey connorlindsey approved these changes

@meryldakin meryldakin Awaiting requested review from meryldakin meryldakin was automatically assigned from knocklabs/product

@andy-knock andy-knock Awaiting requested review from andy-knock andy-knock was automatically assigned from knocklabs/product

@mattmikolay mattmikolay Awaiting requested review from mattmikolay

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaswhyyou @connorlindsey